Fix for Xcode 13 SDK without breaking previous versions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the iOS 15, Apple now made some Attributes Optional rather than Strong, so we have to account for that without breaking developers that haven't updated to the new SDK yet. This change works for both Xcode 12 and 13, and doesn't require the use of #if available() calls.
|
As this library should mimic the behavior and API of Core Bluetooth, it should also have the This should have #if as the API changes. |
|
Similar changes for |
philips77
approved these changes
Jul 30, 2021
|
Let's do other changes in another PR. |
This was referenced Jul 30, 2021
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With iOS 15, Apple now made some Attributes Optional rather than Strong, so we have to account for that without breaking developers that haven't updated to the new SDK yet. This change works for both Xcode 12 and 13, and doesn't require the use of #if available() calls.