Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oslo_aero_3_0a001: Updated shadow files #50

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

gold2718
Copy link
Contributor

  • Updated shadow files from cam6_4_041 to cam6_4_070
  • Use dms_from_ocean from cam_control_mod to avoid circular dependency
  • Detect Zender 2003 dust emission scheme in namelist read and endrun (for now) if Leung 2023 is specified.

Use dms_from_ocean from cam_control_mod to avoid circular dependency
Detect Zender 2003 dust emission scheme in namelist read and
   endrun (for now) if Leung 2023 is specified.
@gold2718
Copy link
Contributor Author

Once this PR is tagged, it will be incorporated into NorESMhub/CAM#197.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reasoning on
if (.not. ndep_stream_active) then

Is not this variable true by default ( Can be turned off in namelist) Or sodes it become false if the deposition is calculated and not read in from file? --> Need output

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is .true. if stream_ndep_data_filename is set:

ndep_stream_active = len_trim(stream_ndep_data_filename)>0 .and. stream_ndep_data_filename/='UNSET'

By default, it will always be set but you can just unset it (e.g., in user_nl_cam):

stream_ndep_data_filename = 'UNSET'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it will be .false. if you are using a chemistry that has NO and NH3, so you will not need to override it in those (common) cases.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it may be possible to remove this from the shadow file without too much work? (For later no as part of this review)

@gold2718 gold2718 merged commit 08c51dd into NorESMhub:noresm_develop Mar 11, 2025
@gold2718 gold2718 changed the title Updated shadow files oslo_aero_3_0a001: Updated shadow files Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants