Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update config to allow access to rpc from external ip on specific port using hostname flag #5716

Merged
merged 6 commits into from
Sep 14, 2024

Conversation

AwaisBinKaleem
Copy link
Contributor

@AwaisBinKaleem AwaisBinKaleem commented Sep 4, 2024

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • added hostname flag in docs that was not available in docs.

Copy link

vercel bot commented Sep 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 11:56pm

Copy link

changeset-bot bot commented Sep 4, 2024

⚠️ No Changeset found

Latest commit: ff74f1d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@AwaisBinKaleem AwaisBinKaleem changed the title allow access to rpc from external ip on specific port using hostname flag Docs update config to allow access to rpc from external ip on specific port using hostname flag Sep 4, 2024
@alcuadrado
Copy link
Member

Thanks! I just updated this a bit to make it more correct with how it works.

@alcuadrado alcuadrado merged commit d725c09 into NomicFoundation:main Sep 14, 2024
7 checks passed
Copy link

gitpoap-bot bot commented Sep 14, 2024

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2024 Hardhat Contributor:

GitPOAP: 2024 Hardhat Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changeset needed This PR doesn't require a changeset
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants