-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: implement additional test cases for the node test reporter (part 2) #5692
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dd54524
chore: support options, save actual output and normalize node interna…
galargh 1d63549
chore: add a test case for top level execution failure
galargh 82cc636
chore: update the test only test without the --test-only flag
galargh d41f8e2
chore: add the test only test with the --test-only flag
galargh 135fb22
chore: add nested it test case
galargh c40ce55
chore: add todo test without the callback
galargh 535b0ea
chore: add test cause for nested error causes
galargh 03002f3
chore: run prettier on test reporter
galargh 473cb03
chore: add a test case for unawaited nested it
galargh 97f7d56
chore: add ignored cases to test only it with the flag
galargh 6194cd5
fix: remove the newline after normalized node internal line
galargh afe66f4
Merge branch 'v-next' into galargh/test-reporter-tests-plus
galargh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,3 +6,5 @@ | |
|
||
# pnpm deploy output | ||
/bundle | ||
|
||
/integration-tests/fixture-tests/*/result.actual.txt |
103 changes: 103 additions & 0 deletions
103
...test-reporter/integration-tests/fixture-tests/execution-failure-test/result.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 12 additions & 0 deletions
12
...dhat-node-test-reporter/integration-tests/fixture-tests/execution-failure-test/result.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
|
||
[31m1) integration-tests/fixture-tests/execution-failure-test/test.ts[39m [31m[3m(101ms)[23m[39m | ||
|
||
|
||
[32m0 passing[39m[90m (131ms)[39m[31m[39m | ||
[31m1 failing[39m | ||
|
||
1) integration-tests/fixture-tests/execution-failure-test/test.ts: | ||
|
||
[31mTest file execution failed (exit code 1).[39m | ||
[90m Did you forget to await a promise?[39m | ||
|
1 change: 1 addition & 0 deletions
1
...hardhat-node-test-reporter/integration-tests/fixture-tests/execution-failure-test/test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
throw new Error("error"); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for a future pr: we need to change the output generated in this case, as it has nothing to do with promises.