Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web-greeter ^3.0.0
A lots of these kind of themes are outdated, depending of an abandoned project:
lightdm-webkit2-greeter
, later renamed toweb-greeter
, made by Antergos team. However, Antergos left some updates and a little direction to what this project should evolve.web-greeter 3.0.0
is now my fork, where I'm trying to develop this project, with some other new features.You can check my fork here (web-greeter 3.1.1), and the API docs here.
Aether theme
As I said previously, these kind of themes are outdated. However, they look pretty nice! Therefore, it would be a shame to not use them, and for that reason I'm trying to fix some big issues about these themes, such as deprecated functions or concepts.
That being said, merging this PR will mean that this theme won't be usable with
lightdm-webkit2-greeter
at all, but it will allow to have features like battery status, brightness controller, layout selector, and a newer JavaScript engine with Chromium.Changes
lightdm.start_session_sync
tolightdm.start_session
user.real_name
touser.display_name
user.name
touser.username
authentication_complete
orshow_prompt
are needed to be attached to its correspondant signals, likelightdm.authentication_complete.connect(() => authentication_complete())
theme_utils.dirlist
needs a callback function due to qt5webengine limitations.