Feat/sub categorys #195
Feat/sub categorys #195
Conversation
Nodrex
requested review from
Nodrex,
shalva97,
nmgalo,
likaGlonti and
tkhat
and removed request for
Nodrex and
shalva97
testomania/src/main/java/com/earth/testomania/home_screen/presentation/AboutBottomSheet.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/data/repository/QuizRepositoryImpl.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/data/source/remote/QuizApi.kt
Outdated
Show resolved
Hide resolved
testomania/src/main/java/com/earth/testomania/technical/domain/repository/QuizRepository.kt
Show resolved
Hide resolved
| @EntryPoint | ||
| @InstallIn(ActivityComponent::class) | ||
| interface ViewModelFactoryProvider { | ||
| fun quizViewModelFactory(): QuizViewModel.Factory |
There was a problem hiding this comment.
why not just pass bundle arguments to the next screen?
There was a problem hiding this comment.
I need QuizCategory at the viewModel initialization, thats why I made this factory
testomania/src/main/java/com/earth/testomania/home_screen/presentation/AboutBottomSheet.kt
Show resolved
Hide resolved
| scope.launch { | ||
| modalBottomSheetState.snapTo(ModalBottomSheetValue.Hidden) | ||
| //snapTo is quicker then hide | ||
| }.invokeOnCompletion { |
There was a problem hiding this comment.
why not have navigator?.navigate(TechnicalTestsScreenDestination(quizCategory)) inside launch {} ?
There was a problem hiding this comment.
it's a bug fix by @Nodrex as I guess, the bottomSheet stays on screen otherwise
There was a problem hiding this comment.
Yes, @kdiakonidze is right, I fixed bottomSheet stays on screen Bug with this solution.
If you @shalva97 have better solution please suggest
There was a problem hiding this comment.
as I check it works without "invokeOnCompletion" block. just calling navigation after bottomSheet hide method in launch block. Any objections on that @Nodrex ?
There was a problem hiding this comment.
ok, lets stay on solution by Nodar
No description provided.