Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sonatype vulnerability detection strategy #21

Merged
merged 13 commits into from
Mar 5, 2022
Merged

Conversation

antoine-coulon
Copy link
Member

@antoine-coulon antoine-coulon commented Feb 2, 2022

Reference issue #19

In this PR :

  • Sonatype vulnerability strategy is added and plugged with the Sonatype API
  • Strategies' functions e.g: hydratePayloadDependencies are not exported anymore to be only used through the factory function scope
  • Formatting issues are fixed on several files

With the growing number of strategies, I'm planning to open a PR which will colocalize each strategy mapper with the strategy definition instead of mixing all different mappers in the same file.

@antoine-coulon antoine-coulon force-pushed the add-sonatype-strategy branch 3 times, most recently from 04a9883 to fcadd91 Compare February 2, 2022 23:47
@antoine-coulon antoine-coulon force-pushed the add-sonatype-strategy branch 12 times, most recently from 2588bc0 to 9069382 Compare February 4, 2022 21:25
@antoine-coulon antoine-coulon force-pushed the add-sonatype-strategy branch 2 times, most recently from 3463c30 to e68c88c Compare February 10, 2022 21:04
@antoine-coulon antoine-coulon marked this pull request as ready for review February 10, 2022 21:37
@antoine-coulon antoine-coulon changed the title Add Sonatype strategy Add Sonatype vulnerability detection strategy Feb 10, 2022
Copy link
Member

@fraxken fraxken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The index.d.ts has not been updated too.

src/strategies/sonatype.js Outdated Show resolved Hide resolved
src/strategies/sonatype.js Outdated Show resolved Hide resolved
src/strategies/sonatype.js Outdated Show resolved Hide resolved
src/strategies/sonatype.js Show resolved Hide resolved
@antoine-coulon antoine-coulon force-pushed the add-sonatype-strategy branch 6 times, most recently from 4471a51 to 4928f83 Compare February 28, 2022 21:12
@fraxken fraxken merged commit c91065f into main Mar 5, 2022
@fraxken fraxken deleted the add-sonatype-strategy branch March 5, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants