-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: plug NodeSecure runtime configuration #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d as the standard runtime config for @nodesecure/ci
… be easily standardized to the nsci standard runtime config format
antoine-coulon
force-pushed
the
plug-runtime-configuration
branch
from
March 14, 2022 18:26
47a7f58
to
a100757
Compare
antoine-coulon
force-pushed
the
plug-runtime-configuration
branch
7 times, most recently
from
March 17, 2022 16:59
fcdcf9f
to
2b6c240
Compare
antoine-coulon
force-pushed
the
plug-runtime-configuration
branch
2 times, most recently
from
March 22, 2022 23:40
73bc823
to
031159a
Compare
tony-go
approved these changes
Mar 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fraxken
reviewed
Mar 23, 2022
antoine-coulon
force-pushed
the
plug-runtime-configuration
branch
4 times, most recently
from
March 23, 2022 23:16
189a326
to
bafb80b
Compare
…nings' such as off, error, warning, object literal
antoine-coulon
force-pushed
the
plug-runtime-configuration
branch
from
March 24, 2022 19:10
bafb80b
to
a67133a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #2
This PR aims to integrate the @nodesecure/rc lib which would be another way to provide a runtime configuration in addition to the API and CLI options.
More generally it also introduces a way to manage different types of configuration in a transparent way for the @nodesecure/ci runner by providing standardization mechanisms towards a Nsci Configuration.
Consequently here are few semantic choices that can be discussed:
Take for example:
These two different configurations can be defined by the user upstream the pipeline runner but we want to abstract this
complexity for the runner which should consume a standard format agnostic of configuration changes.
For that, I propose to describe a target standard format for each of these configurations such as:
Each of the config could then be converted to this format above by implementing a common adapter:
Once the config is adapted to the ExternalRuntimeConfiguration, its an easy work to sanitize/validate/complete the Nsci standard configuration (check src/config/external/standardize.ts)