Added assets.json environment override for including custom css and j… #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s files.
What does this PR cover?
Allowing an assets.json file to override the assets portion of data.json
How can this be tested?
Add an assets.json file with the format:
{ "css": [], "js":[] }Screenshots / Screencast
What gif best describes how you feel about this work?
👍
Reviewers
Review 1
Review 2 (optional)
By adding a +1 you are confirming you have...
I added a minified version in, not sure if that's something you before a release? Let me know if you need any thing else from me. I can merge it into the 2.0 branch, too - I remember you mentioned that we'd need to do that.