Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax warnings in refit check #824

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix syntax warnings in refit check #824

merged 1 commit into from
Apr 17, 2024

Conversation

jmoralez
Copy link
Member

The check added in #823 issues the following syntax warning (which becomes an error in python 3.12) for integers, e.g. 0 is not True:

<string>:1: SyntaxWarning: "is not" with a literal. Did you mean "!="?

this fixes that.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jmoralez jmoralez merged commit 057cacd into main Apr 17, 2024
17 checks passed
@jmoralez jmoralez deleted the refit-check-syntax branch April 17, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant