Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MLflow logging example #892

Merged
merged 16 commits into from
Apr 10, 2024
Merged

add MLflow logging example #892

merged 16 commits into from
Apr 10, 2024

Conversation

cargecla1
Copy link
Contributor

@cargecla1 cargecla1 commented Feb 17, 2024

Addressing MLflow code example to integrate easily
Fixes #825

Addressing MLflow code example to integrate easily Nixtla#825 Nixtla#825
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@CLAassistant
Copy link

CLAassistant commented Feb 17, 2024

CLA assistant check
All committers have signed the CLA.

@cla-ra3426
Copy link

Hello @jmoralez ,
Do you have time to look at this?

Cheers!

nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
Transferring change captured via Fixing bug for issue Nixtla#825 (PR now closed).
To address the first 4 changes suggested via PR 892.
Adding code to  load the saved model and make predictions using MLFlow.
This change makes clear that the latest run ID model is being called. Otherwise, an specific model run_id can be loaded.
As discussed, removed lines of code to publish this examples as an MLFLow integration to train, track and monitor neuralforecast models.
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/examples/MLFlow_and_neuralforecast.ipynb Outdated Show resolved Hide resolved
nbs/mint.json Outdated Show resolved Hide resolved
cargecla1 and others added 2 commits April 5, 2024 23:13
Refining notebook code as suggested.
Names converted to lower case, thank you.

Co-authored-by: José Morales <jmoralz92@gmail.com>
@cargecla1
Copy link
Contributor Author

Hello @jmoralez ,

I just included all suggestions except for a suggestion to remove the #Registering model code section. I explained why on my comment to resolve that suggestion.

Thank you for all these suggestion! :)

cargecla1 and others added 5 commits April 6, 2024 10:25
Removing signature step as suggested.
Changing dataframe to concat.
Removed redundant step to simplify code as suggested.
@jmoralez
Copy link
Member

jmoralez commented Apr 9, 2024

Hey @cargecla1, I just pushed some changes. Please let me know if they look good to you, if they do we can merge this.

@jmoralez jmoralez changed the title Addressing MLflow code issue #825 add MLflow logging example Apr 9, 2024
@cargecla1
Copy link
Contributor Author

Hey @cargecla1, I just pushed some changes. Please let me know if they look good to you, if they do we can merge this.

Hello @jmoralez ,

These changes look great, thank you for these additions!
I believe this is now ready to merge.

Thank you very much for your support!

@jmoralez
Copy link
Member

Thanks a lot for the contribution!

@jmoralez jmoralez merged commit 80df487 into Nixtla:main Apr 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MLflow code example to integrate easily
4 participants