feat: add --no-clobber-old-sections switch #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K900
force-pushed
the
no-clobber-old-sections
branch
from
824acdb
to
6eaa2e9
Compare
12 tasks
vcunat
reviewed
Sep 24, 2023
K900
force-pushed
the
no-clobber-old-sections
branch
from
6eaa2e9
to
2490a52
Compare
Mic92
reviewed
Sep 25, 2023
src/patchelf.cc
Outdated
| @@ -2505,6 +2508,7 @@ static void showHelp(const std::string & progName) | |||
| [--clear-execstack]\n\ | |||
| [--set-execstack]\n\ | |||
| [--rename-dynamic-symbols NAME_MAP_FILE]\tRenames dynamic symbols. The map file should contain two symbols (old_name new_name) per line\n\ | |||
| [--no-clobber-old-sections]\t\tDo not clobber old section values - only use when executable does self-referential tricks.\n\ | |||
There was a problem hiding this comment.
What are self-referential tricks? Can you add more details here?
There was a problem hiding this comment.
Basically anything that relies on things remaining at the same offset in the binary.
Mic92
reviewed
Sep 25, 2023
src/patchelf.cc
Outdated
| @@ -2505,6 +2508,7 @@ static void showHelp(const std::string & progName) | |||
| [--clear-execstack]\n\ | |||
| [--set-execstack]\n\ | |||
| [--rename-dynamic-symbols NAME_MAP_FILE]\tRenames dynamic symbols. The map file should contain two symbols (old_name new_name) per line\n\ | |||
| [--no-clobber-old-sections]\t\tDo not clobber old section values - only use when executable does self-referential tricks.\n\ | |||
There was a problem hiding this comment.
Suggested change
| [--no-clobber-old-sections]\t\tDo not clobber old section values - only use when executable does self-referential tricks.\n\ | |
| [--no-clobber-old-sections]\t\tDo not clobber old section values - only use when executables rely on sections remain at the same offset in the binary.\n\ |
K900
force-pushed
the
no-clobber-old-sections
branch
from
2490a52
to
a633430
Compare
|
How's this phrasing? |
|
Better. Could you also update https://github.com/NixOS/patchelf/blob/master/patchelf.1 ? |
Works around NixOS#520, may be useful for other cursed self-modifying things.
K900
force-pushed
the
no-clobber-old-sections
branch
from
a633430
to
4f710cb
Compare
|
Done. Tried to elaborate a bit on the behavior in the man page too. |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around #520, may be useful for other cursed self-modifying things.