Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --print-os-abi and --set-os-abi options #381

Merged
merged 5 commits into from
Sep 28, 2022
Merged

Conversation

dmsck
Copy link
Contributor

@dmsck dmsck commented Jun 30, 2022

This commit adds an ability to print and change the EI_OSABI field of the ELF header.

dmsck added 3 commits June 30, 2022 14:38
This commit adds an ability to print and change the EI_OSABI field
of the ELF header.

Signed-off-by: Dmitry Moskalchuk <dm@crystax.net>
Signed-off-by: Dmitry Moskalchuk <dm@crystax.net>
Signed-off-by: Dmitry Moskalchuk <dm@crystax.net>
@Mic92
Copy link
Member

Mic92 commented Jul 16, 2022

Changes look good. Can you also add the option to the manpage
and add a test in https://github.com/NixOS/patchelf/tree/master/tests ?

Signed-off-by: Dmitry Moskalchuk <dm@crystax.net>
Signed-off-by: Dmitry Moskalchuk <dm@crystax.net>
@dmsck
Copy link
Contributor Author

dmsck commented Sep 17, 2022

Sorry for long delay. I somehow missed the notification from GitHub.

Here you go. I've updated the documentation and added the required test case.

@Mic92 Mic92 merged commit 683e41d into NixOS:master Sep 28, 2022
@Mic92
Copy link
Member

Mic92 commented Sep 28, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants