Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: build unfree packages #644

Closed
wants to merge 1 commit into from

Conversation

rhendric
Copy link
Member

Closes #194.

Example PR where this would have been helpful: NixOS/nixpkgs#236695

@SuperSandro2000
Copy link
Member

unfree packages are for a reason unfree and most likely fail to build because ofborg cannot obtain the source or we are not allowed to build the packages.

@rhendric
Copy link
Member Author

Wish that had been feedback left on #194. It's hard to pick off small contributions to make when issues are met with silence and only after one does the work do the thumbs-down come out. I mean, unless you don't like growing the set of contributors, in which case great job, keep it up.

On this issue, though: if the source isn't available, the build fails almost immediately. Why is that worse than failing immediately regardless of whether the source is available? Hydra builds non-free packages (I think? I assume that's where they come from when I install them and they aren't built locally); why would ofborg not be allowed to?

@SuperSandro2000
Copy link
Member

Hydra builds non-free packages

No it doesn't because most of the time the restrictive and unfree licenses do not allow that. If hydra would build them ofcourse ofborg could, too.

@rhendric rhendric closed this Jun 13, 2023
@rhendric rhendric deleted the rhendric/build-unfree branch June 13, 2023 16:45
@JulienMalka
Copy link
Member

I don't see how unfree packages could not be buildable at all and still distributed through nixpkgs.

@SuperSandro2000
Copy link
Member

We are not distributing them, we are distributing code to be able to build them if you confirming to their licenses.

@JulienMalka
Copy link
Member

I know this, it doesn't mean we could not have ofborg build them without distributing the results, that is I believe the proposition here. I don't have any strong feeling about it, but I feel like if we are to discard this proposition, let us discard it with legit points.

@rhendric rhendric mentioned this pull request Sep 23, 2023
@SomeoneSerge
Copy link

SomeoneSerge commented Jun 26, 2024

unfree packages are for a reason unfree and most likely fail to build because ofborg cannot obtain the source or we are not allowed to build the packages.

Isn't it exceedingly rare that we are not allowed to build the derivations? Redistribution is usually the point of contention, never evaluation, and (I believe) rarely the "building". We can literally count these things by checking how many attributes with !meta.license.free there are, and how many derivations rely on requireFile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build unfree packages
4 participants