Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eval aarch64-darwin rather than i686-linux #588

Merged
merged 1 commit into from
Mar 24, 2022
Merged

eval aarch64-darwin rather than i686-linux #588

merged 1 commit into from
Mar 24, 2022

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Jan 2, 2022

I don't think anyone still runs nixpkgs-review on 32-bit x86.

@Mic92
eval aarch64-darwin rather than i686-linux
77e4de8 
I don't think anyone still runs nixpkgs-review on 32-bit x86.
@Mic92
Copy link
Member Author

Mic92 commented Jan 2, 2022

We need this arch for nixpkgs-review eval.

@zowoq
Copy link
Contributor

zowoq commented Mar 17, 2022

@cole-h Would be good to get this merged.

@cole-h
Copy link
Member

cole-h commented Mar 17, 2022

I'm hesitant to do so because of: #583 (comment)

I may have time to test and babysit this next week.

@Mic92
Copy link
Member Author

Mic92 commented Mar 17, 2022

Is aarch64-darwin not smaller than x86 32 after all?

@cole-h
Copy link
Member

cole-h commented Mar 24, 2022

Well, let's give this a shot...

@cole-h cole-h merged commit db5293a into NixOS:released Mar 24, 2022
@cole-h
Copy link
Member

cole-h commented Mar 24, 2022

Things seem to be fine for now, and we've got our first aarch64-darwin "Changed Paths" result! https://gist.github.com/GrahamcOfBorg/f1ca8c1f3fc64e06c5c120bab5926c83

@Mic92 Mic92 deleted the aarch64-darwin branch March 25, 2022 07:45
@Mic92 Mic92 restored the aarch64-darwin branch March 25, 2022 07:47
@Mic92 Mic92 deleted the aarch64-darwin branch March 25, 2022 07:47
@Mic92 Mic92 restored the aarch64-darwin branch March 25, 2022 07:47
@Mic92
Copy link
Member Author

Mic92 commented Mar 25, 2022

tell me when its save to enable this in nixpkgs-review as a caching option for aarch64.

@cole-h
Copy link
Member

cole-h commented Mar 25, 2022

It usually takes ~a week for the evaluators to get ~low on memory. See this graph: https://nix.ci/prometheus/graph?g0.expr=node_memory_MemFree_bytes%7Binstance!%3D%22aarch64.nixos.community%3A9100%22%2Cinstance!%3D%22136.144.57.217%3A9100%22%7D%20%2F%201024%20%2F%201024%20%2F%201024&g0.tab=0&g0.stacked=0&g0.range_input=2w.

I'd said go for it, unless you want to wait that long and see if ofborg is still happy when it gets that low (and even then, low is around 30 GiB of free memory lol).

@Mic92 Mic92 mentioned this pull request Mar 26, 2022
Merged
@zowoq zowoq mentioned this pull request Mar 31, 2022
Closed
13 tasks
Artturin added a commit to Artturin/nixpkgs that referenced this pull request Apr 1, 2022
@Artturin
.github/workflows/basic-eval.yml: only run if manually triggered
36c3641 
ofborg should have obsoleted this with NixOS/ofborg#588 (comment)
NixOS#166599 (comment)

this is still useful to have around for act usage
@Artturin Artturin mentioned this pull request Apr 1, 2022
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mic92 @zowoq @cole-h @SuperSandro2000