nixos boot extra-utils: ensure we use working lvm2

[vcunat]

This fixes the problem for me, though it's a bit hacky that we basically
re-link cryptsetup to a different lvm2 "version".
The recursion probably isn't needed now, but I think theoretically
it might be useful.

Also show those more results/failures in the build log.

Motivation for this change

Fixes #96197.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[jonringer]

I am able to run nixos tests again

[flokli]

lvm2 provides libdevmapper, which is used to build cyptsetup (and systemd uses libcryptsetup for its cryptsetup support).
We finally build a lvm2 with udev support (which is used in the normal system).
Also, see the commit message in 72c8ed0.

For initrd, it probably doesn't matter much which lvm2 we use, as systemd isn't available there.

[vcunat]

The problem was that if we use the less featurful one, dmsetup won't load due to missing symbol(s). EDIT: so one alternative would be to have both/all without udev support (for initrd), if I get you right.

[flokli]

I assume we currently only have one dmsetup available, from lvm2.bin.

We might be able to just use dmsetup from lvm2.override { udev = null; }'s bin output - and only end up with one lvm2*.lib store path.

[flokli]

@vcunat something like this:

diff --git a/nixos/modules/system/boot/stage-1.nix b/nixos/modules/system/boot/stage-1.nix
index ec5eadf69c3..aab9e3cdec6 100644
--- a/nixos/modules/system/boot/stage-1.nix
+++ b/nixos/modules/system/boot/stage-1.nix
@@ -87,7 +87,9 @@ let
   # copy what we need.  Instead of using statically linked binaries,
   # we just copy what we need from Glibc and use patchelf to make it
   # work.
-  extraUtils = pkgs.runCommandCC "extra-utils"
+  extraUtils = let
+    # Use lvm2 without udev support, which is the same lvm2 we already have in the closure anyways
+    lvm2 = pkgs.lvm2.override { udev = null; }; in pkgs.runCommandCC "extra-utils"
     { nativeBuildInputs = [pkgs.buildPackages.nukeReferences];
       allowedReferences = [ "out" ]; # prevent accidents like glibc being included in the initrd
     }
@@ -111,8 +113,8 @@ let
       copy_bin_and_libs ${pkgs.utillinux}/sbin/blkid
 
       # Copy dmsetup and lvm.
-      copy_bin_and_libs ${getBin pkgs.lvm2}/bin/dmsetup
-      copy_bin_and_libs ${getBin pkgs.lvm2}/bin/lvm
+      copy_bin_and_libs ${getBin lvm2}/bin/dmsetup
+      copy_bin_and_libs ${getBin lvm2}/bin/lvm
 
       # Add RAID mdadm tool.
       copy_bin_and_libs ${pkgs.mdadm}/sbin/mdadm

[vcunat]

Yes, sounds good from what I know.

[FRidh]

I've pushed @flokli 's suggestion as f6286de. Thanks!

[jonringer]

since you pushed to master, we should probably push master to staging-next, staging-next to staging. Currently all other branches are broken

[FRidh]

already done 😉