Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.somajo: 2.0.4 -> 2.0.5 #84878

Merged
merged 1 commit into from
Apr 10, 2020
Merged

python3Packages.somajo: 2.0.4 -> 2.0.5 #84878

merged 1 commit into from
Apr 10, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

  • Add heuristics for ambiguous quotation marks (issue gimp 2.8 #11).
  • Avoid false positives for emoticons that contain a space (issue
    afew and alot updates #12).
  • Correctly tokenize obfuscated email addresses that contain spaces.
  • Do not split tl;dr and its German variant zl;ng.

https://github.com/tsproisl/SoMaJo/releases/tag/v2.0.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
python3Packages.somajo: 2.0.4 -> 2.0.5
b7b383d 
Changelog:

- Add heuristics for ambiguous quotation marks (issue NixOS#11).
- Avoid false positives for emoticons that contain a space (issue
  NixOS#12).
- Correctly tokenize obfuscated email addresses that contain spaces.
- Do not split tl;dr and its German variant zl;ng.

https://github.com/tsproisl/SoMaJo/releases/tag/v2.0.5
jonringer
jonringer approved these changes Apr 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 84878 1

2 packages built: - python37Packages.somajo - python38Packages.somajo

@jonringer jonringer merged commit d8a7d04 into NixOS:master Apr 10, 2020
@danieldk danieldk deleted the somajo-2.0.5 branch August 17, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danieldk @jonringer