Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust: add support for armv6l-linux and armv7l-linux #73472

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

lopsided98
Copy link
Contributor

@lopsided98 lopsided98 commented Nov 15, 2019

Motivation for this change

Extremely similar to #72480, except with a different mapping function name and location, bootstrap tarball hashes for armv6l, and another platform string fixup in .cargo/config.

Note that the rust does not build on armv6l right now because bootstrap rustc segfaults while building libc since the upgrade (of the bootstrap compiler) to 1.38.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

@ofborg ofborg bot added the 6.topic: rust label Nov 15, 2019
@lopsided98 lopsided98 force-pushed the rust-arm branch 2 times, most recently from d80d92b to 6846738 Compare November 16, 2019 03:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 16, 2019
@bjornfor bjornfor added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Nov 16, 2019
@lopsided98
Copy link
Contributor Author

1.39.0 does not build on armv6l or armv7l due to rust-lang/rust#62896. I was able to successfully build 1.38.0 for armv6l.

@Mic92 Mic92 merged commit 435c3ec into NixOS:master Nov 29, 2019
@lopsided98 lopsided98 deleted the rust-arm branch March 4, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 6.topic: rust 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants