Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Attempt to bump tensorflow-tensorboard to version 2.0
Things done
Protobuf on its own functions normally and passes its test suite. That said, I noticed that the python module fails its own test suite for any python-protobuf-3.x package. Can someone else confirm? This PR implicitly adds the protobuf 3.10 python package.
On the python side, I will note that tensorflow-tensorboard-2.0 tests pass using protobuf-3.10 -- this test suite should have heavy dependence on protobuf and might be a good proxy(?)
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)Notify maintainers
cc (no maintainers exist for protobuf)