Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luaPackages.luaexpat: Downgrade to fix prosody issue and match typical distros #63566

Merged
merged 1 commit into from
Jun 24, 2019
Merged

luaPackages.luaexpat: Downgrade to fix prosody issue and match typical distros #63566

merged 1 commit into from
Jun 24, 2019

Conversation

Shados
Copy link
Member

@Shados Shados commented Jun 20, 2019

Motivation for this change

Matches version used on most distros. Fixes an issue with prosody. Detailed reasoning behind this can be found here. As mentioned there, I'm tracking the prosody issue for it, so if some suitable resolution arises there I'll PR an update and remove the version specifier in luarocks-packages.csv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Shados
luaPackages.luaexpat: Downgrade to fix issue and match typical distros
7a9b4b9 
Matches version used on most distros. Fixes an issue with prosody.
Detailed reasoning behind this can be found
[here](NixOS#63108 (comment)).
@teto
Copy link
Member

teto commented Jun 24, 2019

not too keen on downgrading but the downgrade is little and it's not used much anyway. Thanks for following up on your PR. Much appreciated.

@teto teto merged commit 3ca771c into NixOS:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: lua 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shados @teto