magma: 2.0.2 -> 2.5.0

[tbenst]

Motivation for this change

Without magma, many linalg functions in pytorch are broken on GPU. I also had to update magma to support newer versions of CUDA.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Assured whether relevant documentation is up to date
• Fits CONTRIBUTING.md.

---

[tbenst]

@wavewave let me know if you have any input! (If you are the former “ianwookim” that is)

[stites]

Heads-up, MAGMA also allows for building with MKL support and I might try to shoe-horn this build optimization into #65041 or layer on an additional PR here.

[tbenst]

Now that PyTorch 1.2 #65041 (comment) is ready, this is blocking. Would someone be able to review? Thanks!

Edit: I plan to remove the changes to pytorch, and just have the addition of magma, but would be great to make all changes in one swoop

[stites]

It's worth pointing out that I have been using this code and running the full pytorch test suite with it (on cudatoolkit 10 and 9.2), so you can consider this functional and tested. Code changes get a +1 from me.

[wavewave]

@tbenst thank you for upgrading this! 👍

[tbenst]

Thanks @FRidh your suggestion worked. @wavewave should I update your handle from ianwookin to wavewave?

[wavewave]

I checked this works. btw, please take the maintainership since I am not very familar with recent updates of magma. :-)
(and it is more desirable to be listed as ianwookim as listed in /maintainers/maintainer-list.nix.)
Thanks again! @tbenst

[FRidh]

undefined variable 'wavewave' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/eval-2-shlevy.ewr1.nix.ci/pkgs/development/libraries/science/math/magma/default.nix:46:39

[tbenst]

@wavewave @FRidh done!

[tbenst]

Just reviewed #65041 and realized that @stites's excellent work building on-top of this pull request for adding MKL might best be added here. Let me know if you want to be added as a maintainer?

[stites]

I'm probably not a good maintainer for magma -- it's a slightly magical build system which I haven't fully figured out. I'd be happy to be added as a maintainer as a second pair of eyes, however.

[tbenst]

Ok, just wanted to make sure that I acknowledged your contributions to this pull request :). In that case I think this is good to go!