Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh-audit: init at 1.7.0 #60519

Merged
merged 1 commit into from
May 1, 2019
Merged

ssh-audit: init at 1.7.0 #60519

merged 1 commit into from
May 1, 2019

Conversation

4z3
Copy link
Contributor

@4z3 4z3 commented Apr 30, 2019 •
edited
Loading

Motivation for this change

ssh-audit is not packaged, yet.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lassulus
Copy link
Member

tested with nix-review and checked some configs via ssh-audit $hostname

tomberek
tomberek approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@tomberek tomberek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, runs, functions on Ubuntu. No reverse dependencies.

aanderse
aanderse requested changes Apr 30, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a few minor nitpicks.

pkgs/tools/security/ssh-audit/default.nix Show resolved Hide resolved
pkgs/tools/security/ssh-audit/default.nix Show resolved Hide resolved
pkgs/tools/security/ssh-audit/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/ssh-audit/default.nix Outdated Show resolved Hide resolved
@Lassulus Lassulus force-pushed the ssh-audit branch 2 times, most recently from d5094dc to fff80ba Compare April 30, 2019 23:01
@Lassulus
Copy link
Member

@GrahamcOfBorg build ssh-audit

@Lassulus Lassulus merged commit 38b1f61 into NixOS:master May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lassulus Lassulus Lassulus approved these changes

@aanderse aanderse aanderse requested changes

@tomberek tomberek tomberek approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@4z3 @Lassulus @tomberek @aanderse