-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua: convert some more packages #55747
Conversation
I would like to run a nix-review on it before merging, but I have some problems with it so don't merge yet. |
nix-review shows some errors which is strange since building just lua-zlib works fine. Maybe zlib is not properly propagated and I should set ZLIB_DIR
but if I run sile could also be updated to use lua env as I did in https://github.com/teto/nixpkgs/tree/lua_envs |
0c6c389
to
a7ef769
Compare
for some reason lfs.so (luafilesystem) isn't brought in the luakit environment... will check when I have more time. |
cf90854
to
66ef655
Compare
66ef655
to
c4081b9
Compare
when looking into more details, it seems like several lua environments are generated via nix build luakit, one with lfs.so as expected and the other without inputs. I am not sure why, must be a bug somewhere in the lua infrastructure. |
Some commits that can already be cherry-picked? |
@Mic92 thanks for proposing
|
c4081b9
to
ee43679
Compare
Cherry-picked all three. Can be removed with an interactive rebase from this pr now. |
1ddb491
to
11f5951
Compare
@GrahamcOfBorg eval |
the package was passing the package version of a specific lua interpreter which made nix review fails. (Also in the end it was just using luajit).
gcc -c extension/clib/msg.c -o extension/clib/msg.o gcc -c extension/clib/ipc.c -o extension/clib/ipc.o gcc -c extension/clib/luakit.c -o extension/clib/luakit.o gcc -o luakit.so extension/luajs.o extension/ipc.o extension/extension.o extension/log.o extension/script_world.o extension/scroll.o extension/clib/page.o extension/clib/dom_document.o extension/clib/soup.o extension/clib/dom_element.o extension/clib/msg.o extension/clib/ipc.o extension/clib/luakit.o common/luajs.o common/luaobject.o common/luayield.o common/util.o common/luautil.o common/luauniq.o common/property.o common/ipc.o common/luah.o common/luaserialize.o common/resource.o common/lualib.o common/luaclass.o common/clib/timer.o common/clib/utf8.o common/clib/ipc.o common/clib/luakit.o common/clib/regex.o common/tokenize.o rm -rf doc/apidocs mkdir doc/apidocs luajit ./build-utils/docgen/makedoc.lua /nix/store/zrarsvfma3zfc00dg99lfq3s0p163yv9-luajit-2.1.0-beta3/bin/luajit: build-utils/docgen/gen.lua:2: module 'lib.lousy.util' not found: no field package.preload['lib.lousy.util'] no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/lib/lua/5.1/lib/lousy/util.lua' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/share/lua/5.1/lib/lousy/util.lua' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/share/lua/5.1/lib/lousy/util/init.lua' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/lib/lua/5.1/lib/lousy/util/init.lua' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/share/luajit-2.1.0-beta3/lib/lousy/util.lua' no file 'build-utils/lib/lousy/util.lua' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/lib/lua/5.1/lib/lousy/util.so' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/share/lua/5.1/lib/lousy/util.so' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/lib/lua/5.1/lib.so' no file '/nix/store/xa7a51dw6hvx0r4ka65blxha5660akn9-luajit-2.1.0-beta3-env/share/lua/5.1/lib.so' stack traceback: [C]: in function 'require' build-utils/docgen/gen.lua:2: in main chunk [C]: in function 'require' ./build-utils/docgen/makedoc.lua:9: in main chunk [C]: at 0x00406330 make: *** [Makefile:85: doc/apidocs/index.html] Error 1 note: keeping build directory '/tmp/nix-build-luakit-2.1.drv-1' builder for '/nix/store/dzsw6a59vsz5s2h0zipa1805qk2ny6qi-luakit-2.1.drv' failed with exit code 2 error: build of '/nix/store/dzsw6a59vsz5s2h0zipa1805qk2ny6qi-luakit-2.1.drv' failed
11f5951
to
83d99bd
Compare
closed in favor of #63108 |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)