luarocks: support more commands: pack/build #54454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine. Feel free to add yourself as luarocks maintainer. I am OK with adding luarocks-nix, but I think it is better to have |
better support for luarocks in a shell (helpful to develop on luarocks). Also adds unpacker for src.rock/rockspec files. Also allows to use luarocks to build cmake based rocks.
luarocks-nix is a fork of luarocks that adds a "nix" command capable of converting luarocks package descriptions into nix derivations (though nixpkgs is still missing the lua infrastructure).
|
cool. I've added myself as a maintainer and added a luarocks-nix.nix. |
GrahamcOfBorg
added
10.rebuild-darwin: 11-100
and removed
10.rebuild-darwin: 1-10
labels
21 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Extracted from #33903. Endgoal is to improve lua support.
Some luarocks commands wouldn't work (pack/unpack) so I've added the required dependencies.
the 2nd commit is my fork of luarocks that converts luarocks packages into nix packages (providing the lua infrastructure in #33903 gets merged). As such it might represent some dead code so feel free to merge only the first commit.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)