grpc, pythonPackges.grpcio, pythonPackages.grpcio-tools: update to 1.16.1 #50672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build grpc pythonPackages.grpcio python3Packages.grpcio pythonPackages.grpcio-tools python3Packages.grpcio-tools python3Packages.tensorflow pythonPackages.tensorflow |
|
Failure on aarch64-linux (full log) Attempted: grpc, pythonPackages.grpcio, python3Packages.grpcio, pythonPackages.grpcio-tools, python3Packages.grpcio-tools, pythonPackages.tensorflow The following builds were skipped because they don't evaluate on aarch64-linux: python3Packages.tensorflow Partial log (click to expand)
|
|
Failure on x86_64-linux (full log) Attempted: grpc, pythonPackages.grpcio, python3Packages.grpcio, pythonPackages.grpcio-tools, python3Packages.grpcio-tools, pythonPackages.tensorflow The following builds were skipped because they don't evaluate on x86_64-linux: python3Packages.tensorflow Partial log (click to expand)
|
lopsided98
force-pushed
the
grpc-update
branch
from
e79e759 to
a61c05f
Compare
|
I added a commit which applies protocolbuffers/protobuf#4862 to make protobuf compatible with Python 3.7. |
lopsided98
force-pushed
the
grpc-update
branch
from
a61c05f to
eb1bc33
Compare
|
@GrahamcOfBorg build grpc pythonPackages.grpcio python3Packages.grpcio pythonPackages.grpcio-tools python3Packages.grpcio-tools pythonPackages.protobuf python3Packages.protobuf |
|
@GrahamcOfBorg build pythonPackages.tensorflow |
|
Success on x86_64-linux (full log) Attempted: pythonPackages.tensorflow Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: grpc, pythonPackages.grpcio, python3Packages.grpcio, pythonPackages.grpcio-tools, python3Packages.grpcio-tools, pythonPackages.protobuf, python3Packages.protobuf Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: grpc, pythonPackages.grpcio, python3Packages.grpcio, pythonPackages.grpcio-tools, python3Packages.grpcio-tools, pythonPackages.protobuf, python3Packages.protobuf Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: pythonPackages.tensorflow Partial log (click to expand)
|
|
Seems |
worldofpeace
approved these changes
Nov 27, 2018
|
The protobuf patch introduced here does not apply when using another (older) protobuf (e.g. protobuf_3_1). (PR incoming) |
samueldr
added a commit
to samueldr/nixpkgs
that referenced
this pull request
Dec 10, 2018
Change introduced in NixOS#50672. The patch does not apply on older protobuf like protobuf3_1 ``` $ nix-build -E 'with import ./. { }; python3Packages.protobuf.override { protobuf = protobuf3_1; }' unpacking sources unpacking source archive /nix/store/1zdyl0cxaa8ha2v1zp75zzdjd6j99d0m-source source root is source setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/util/python/BUILD patching sources applying patch /nix/store/yagx7hvylnnjq7lxbcia0y5lq1r736w3-0a59054c30e4f0ba10f10acfc1d7f3814c63e1a7.patch patching file google/protobuf/pyext/descriptor.cc Hunk #1 succeeded at 55 (offset -1 lines). patching file google/protobuf/pyext/descriptor_containers.cc patching file google/protobuf/pyext/descriptor_pool.cc Hunk #1 succeeded at 47 (offset -1 lines). patching file google/protobuf/pyext/extension_dict.cc Hunk #1 FAILED at 53. 1 out of 1 hunk FAILED -- saving rejects to file google/protobuf/pyext/extension_dict.cc.rej patching file google/protobuf/pyext/message.cc Hunk #1 succeeded at 82 (offset 3 lines). Hunk #2 succeeded at 1425 (offset -104 lines). ``` Since the patch isn't necessary on python versions older than 3.7, let's only apply it for version 3.7. This means that most things using older protobuf implementation will now be able to build when using an older pythonPackage set (as is most probably the case anyway). This still leaves protobuf 3.1 using packages hanging, but the errors will be localized to those that would be breaking anyway with the upgrade to 3.7 as default python.
dotlambda
pushed a commit
to samueldr/nixpkgs
that referenced
this pull request
Dec 11, 2018
…g with it Change introduced in NixOS#50672. The patch does not apply on older protobuf like protobuf3_1 ``` $ nix-build -E 'with import ./. { }; python3Packages.protobuf.override { protobuf = protobuf3_1; }' unpacking sources unpacking source archive /nix/store/1zdyl0cxaa8ha2v1zp75zzdjd6j99d0m-source source root is source setting SOURCE_DATE_EPOCH to timestamp 315619200 of file source/util/python/BUILD patching sources applying patch /nix/store/yagx7hvylnnjq7lxbcia0y5lq1r736w3-0a59054c30e4f0ba10f10acfc1d7f3814c63e1a7.patch patching file google/protobuf/pyext/descriptor.cc Hunk #1 succeeded at 55 (offset -1 lines). patching file google/protobuf/pyext/descriptor_containers.cc patching file google/protobuf/pyext/descriptor_pool.cc Hunk #1 succeeded at 47 (offset -1 lines). patching file google/protobuf/pyext/extension_dict.cc Hunk #1 FAILED at 53. 1 out of 1 hunk FAILED -- saving rejects to file google/protobuf/pyext/extension_dict.cc.rej patching file google/protobuf/pyext/message.cc Hunk #1 succeeded at 82 (offset 3 lines). Hunk #2 succeeded at 1425 (offset -104 lines). ``` Since the patch isn't necessary on python versions older than 3.7, let's only apply it for version 3.7. This means that most things using older protobuf implementation will now be able to build when using an older pythonPackage set (as is most probably the case anyway). This still leaves protobuf 3.1 using packages hanging, but the errors will be localized to those that would be breaking anyway with the upgrade to 3.7 as default python.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Updates grpc and related packages to 1.16.1:
I removed the grpc dependency from grpcio-tools, because it is not used.
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)