[WIP] pythonPackages.numpy-mkl: refactor adding mkl support #48676
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Would love to see packaging python applications with mkl support similar to how
conda
packagesmkl
. I realize that this pull request is very trivial and probably not the correct approach to packaging mkl into numpy and would love any input. Hopefully this pull request gets enough input that it can be used as a guide on how to integrate mkl with python packages. Packages that I would like to eventually target areNumExpr
,SciPy
, andScikit-Learn
.I would like to especially thank @bhipple for the
mkl
PR! I have been wanting that for a long time but did not know how to do it. If at all possible I would like to hear input from @bhipple and @markuskowa. @smaret you provided great input making sure that it works with darwin and since I do not have a mac I would appreciate any help.I am aware that this will cause mass rebuilds and will eventually move to staging when it is working. Currently if it is on staging it will require mass rebuilds making it harder to test.
Things done
Adding mkl support for
numpy
. As of now this PR does not succeed in building. The numpy tests fail.sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)