Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firefox, thunderbird: disable wrapped derivations for Darwin #376849

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Jan 26, 2025

$ nix build --file . thunderbird
error:
       … while calling a functor (an attribute set with a '__functor' attribute)
         at /Users/ihrachys/src/nixpkgs/darwin-disable-wrapped-mozilla-apps/pkgs/applications/networking/mailreaders/thunderbird/wrapper.nix:10:2:
            9|
           10| (wrapFirefox browser (
             |  ^
           11|   {

       … while calling the 'throw' builtin
         at /Users/ihrachys/src/nixpkgs/darwin-disable-wrapped-mozilla-apps/pkgs/applications/networking/browsers/firefox/wrapper.nix:478:5:
          477|   if stdenv.isDarwin then
          478|     throw "Wrapped app is not supported on MacOS. Use ${applicationName}-unwrapped instead."
             |     ^
          479|   else

       error: Wrapped app is not supported on MacOS. Use thunderbird-unwrapped instead.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

The wrapper is not compatible with Darwin. Making the wrapper work on
the platform is not simple because MacOS bundles don't allow a simple
wrapper script as a substitute for an app entrypoint.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jan 26, 2025
@github-actions github-actions bot added the 8.has: documentation This PR adds or changes documentation label Jan 26, 2025
@booxter booxter requested a review from mweinelt January 26, 2025 01:03
@booxter booxter changed the title Darwin disable wrapped mozilla apps firefox, thunderbird: disable wrapped derivations for Darwin Jan 26, 2025
@booxter booxter force-pushed the darwin-disable-wrapped-mozilla-apps branch from 25f1438 to 0fb51ff Compare January 26, 2025 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: darwin Running or building packages on Darwin 8.has: documentation This PR adds or changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant