python312Packages.jax: 0.4.38 -> 0.5.0 #374810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also update jax-cuda12-pjrt and jax-cuda12-plugin? |
Sure, done ! |
|
Getting this failure on Darwin: There are already disabled tests for jax for the same error, so we should probably add this test case to the list for the platform. |
Yes, I have seen this nanobind failure occuring on several other packages. |
|
For |
Yes. They have some integration tests I think? I've also noticed that Jax test suite hogs a lot of memory (apparently my Linux builder with 20gb RAM is not enough) and swaps until it times out. I see this with the older version too. Perhaps on a related note, nanobind itself fails in test suite for me (on Darwin at least) because jaxlib leaks. Something is really wrong about jax/nanobind combination. |
Yes, there might be some issues of this kind. |
|
I will retry. Isn't python313Packages.jax in the list of broken packages in your nixpkgs-review output for Darwin too? Do you have logs from the failure? |
I am facing the same
|
GaetanLepage
force-pushed
the
jax-bin
branch
2 times, most recently
from
b726950 to
3b9ee84
Compare
|
|
I am also running into this (building with Although in my case, since the tests run on cpu anyways (#256230) there isn't much of a point so I just |
|
|
SuperSandro2000
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Maybe we should just skip the Jax tests all together?
There was a problem hiding this comment.
The jax tests are not too bad. What tends to be unreliable is the tests in other packages that use jax.
The issue is that so many things are currently broken that it is tedious to separate regressions from overall noise...
|
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
cc @samuela @natsukium
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.