Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hatch: skip failing tests #371743

Merged
merged 1 commit into from
Jan 9, 2025
Merged

hatch: skip failing tests #371743

merged 1 commit into from
Jan 9, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jan 7, 2025

Things done

Fix hatch build by skipping failing tests.
They have all been reported upstream:

Fixes #366359

cc @onny

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Atemu Atemu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Intention and diff LGTM.

I'd like to give maintainers a few days to veto but otherwise, if this builds fine now, I'd like to merge.

@eljamm eljamm added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 7, 2025
Copy link
Contributor

@MattSturgeon MattSturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, I just spent ages debugging this myself only to stumble on your PR being referenced from an upstream issue 😅

The changes look good and fix the build on my machine.

Could you mark this as fixing #366359 ?

@MattSturgeon MattSturgeon added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 7, 2025
@MattSturgeon
Copy link
Contributor

MattSturgeon commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 371743


x86_64-linux

⏩ 1 package blacklisted:
  • tests.nixos-functions.nixos-test
❌ 1 package failed to build:
  • tests.devShellTools.nixos
✅ 7 packages built:
  • hatch
  • hatch.dist
  • nixos-build-vms
  • tests.testers.lycheeLinkCheck.network
  • tests.testers.nixosTest-example
  • tests.testers.runNixOSTest-example
  • tests.trivial-builders.references

EDIT: the failing test seems unrelated, guessing that's already broken on staging?

@Atemu Atemu merged commit a022b78 into NixOS:staging-next Jan 9, 2025
65 of 69 checks passed
@GaetanLepage GaetanLepage deleted the hatch branch January 9, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants