-
-
Notifications
You must be signed in to change notification settings - Fork 15.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hatch: skip failing tests #371743
hatch: skip failing tests #371743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intention and diff LGTM.
I'd like to give maintainers a few days to veto but otherwise, if this builds fine now, I'd like to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ugh, I just spent ages debugging this myself only to stumble on your PR being referenced from an upstream issue 😅
The changes look good and fix the build on my machine.
Could you mark this as fixing #366359 ?
|
Things done
Fix
hatch
build by skipping failing tests.They have all been reported upstream:
test_spec.py::TestCoreMetadataV*
fail withAssertionError
pypa/hatch#1877Fixes #366359
cc @onny
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.