-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: remove obsolete aligned allocation workarounds #370749
Conversation
960a259
to
b0341c2
Compare
b0341c2
to
50fe44c
Compare
50fe44c
to
335751d
Compare
335751d
to
fc045af
Compare
LGTM overall, are you still searching for more occurrences or anything before marking it ready? |
Waiting for |
A rebase to latest master should clear the Eval / Tag job after #370857. I'd be interested in seeing the result for it, which maintainers are requested and which of them is failing. |
Will do, after I can get a |
silently skips his own, not so important, builds on the community builder... |
It’s the Darwin one FWIW, the Linux one is idle :) |
Yeah, I only use the darwin one, too. I build Linux stuff on my own machine. |
fc045af
to
205c169
Compare
@wolfgangwalther This showed up quite noisily on my open tab, though refreshing seems to coalesce it: |
Yeah, odd. I saw the same thing briefly. Odd, because I've never seen this with ofborg. But could be because we have been doing a lot more reviewer requests here (~30) at once than we ever did with ofborg, which was limited to 10. We should do something about that, discussed in #366046 (comment) |
FWIW I always found the “pick a ~random subset of maintainers and ping them, drop all the rest” thing somewhat dubious. (But I don’t know if I have a better concrete proposal.) |
Yeah... doing it one by one will generate that way but then GitHub cleans it up later. |
|
The first deliverable of my ~100‐commit branch cleaning up obsolete Darwin stuff. Still needs building, and a
staging
PR for the change to Node.js.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.