gnuradio: fix tests with an upstream patch for numpy_2 #365839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ofborg build gnuradio |
This was referenced Dec 17, 2024
Merged
ofborg
bot
added
the
11.by: package-maintainer
| # https://github.com/gnuradio/gnuradio/issues/7458 | ||
| (fetchpatch { | ||
| name = "gnuradio-numpy_2-compatibility.patch"; | ||
| url = "https://github.com/gnuradio/gnuradio/commit/4be7ac7b5095a4c0d394456934102b8666b7c68c.patch"; |
There was a problem hiding this comment.
Suggested change
| url = "https://github.com/gnuradio/gnuradio/commit/4be7ac7b5095a4c0d394456934102b8666b7c68c.patch"; | |
| url = "https://github.com/gnuradio/gnuradio/commit/8fbc5eb4b7214a4cb029ccae97205a85d49bdd48.patch"; |
This is the merged commit, in case the PR branch is ever deleted.
The hash should be the same but I didn't check.
LGTM otherwise
There was a problem hiding this comment.
You are right, thanks for the refinement and for explaining. Fixed it and will merge when CI is green enough.
doronbehar
force-pushed
the
pkg/gnuradio@numpy2
branch
from
ab02c83 to
1111548
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Things done
nix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.