Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo: 0.136.5 -> 0.138.0 #355783

Merged
merged 1 commit into from
Nov 14, 2024
Merged

hugo: 0.136.5 -> 0.138.0 #355783

merged 1 commit into from
Nov 14, 2024

Conversation

FedericoSchonborn
Copy link
Member

@FedericoSchonborn FedericoSchonborn commented Nov 14, 2024

https://github.com/gohugoio/hugo/releases/tag/v0.137.0
https://github.com/gohugoio/hugo/releases/tag/v0.137.1
https://github.com/gohugoio/hugo/releases/tag/v0.138.0

I added withdeploy as to not break compatibility with previous versions, maybe putting it behind a flag would be a good idea.

For reference, from the v0.137.0 release notes:

Note that we have no longer build the deploy feature in the standard and extended archives. If you need that, download archives with withdeploy in the filename. See instalation for details. You can read gohugoio/hugo#12994 for more on the motivation behind this, but for one, it shaves off about 40% of the binary size.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FedericoSchonborn
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • hugo

Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM

@drupol drupol merged commit 8d3ac9b into NixOS:master Nov 14, 2024
41 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants