waagent: fix build #354183
Merged
waagent: fix build #354183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest Python to avoid NixOS#353830 Co-authored-by: Sarah Stoltze <sarah.stoltze@maersk.com>
camelpunch
force-pushed
the
waagent-upgrade-python
branch
from
b8493de to
c73f4a5
Compare
|
Why was this pinned to python39 in the first place? |
|
As the original derivation mentions, the upstream GitHub workflow tests against several ancient versions of Python, and 39 is (still) the most recent. |
|
But I would guess that most people using this derivation want to put an up-to-date NixOS VM on Azure. |
|
Thanks! |
|
We have discovered that this PR fixes the build, but the waagent service does not start up with python 3.12 Nov 11 09:16:35 localhost systemd[1]: Started Windows Azure Agent Service.
Nov 11 09:16:35 localhost waagent[14455]: Traceback (most recent call last):
Nov 11 09:16:35 localhost waagent[14455]: File "/nix/store/najm5yzvdysjvrc22m8rjzf8gvhqlbxi-waagent-2.11.1.12/lib/python3.12/site>
Nov 11 09:16:35 localhost waagent[14455]: import azurelinuxagent.agent as agent
Nov 11 09:16:35 localhost waagent[14455]: File "/nix/store/najm5yzvdysjvrc22m8rjzf8gvhqlbxi-waagent-2.11.1.12/lib/python3.12/site>
Nov 11 09:16:35 localhost waagent[14455]: from azurelinuxagent.ga import logcollector, cgroupconfigurator
Nov 11 09:16:35 localhost waagent[14455]: File "/nix/store/najm5yzvdysjvrc22m8rjzf8gvhqlbxi-waagent-2.11.1.12/lib/python3.12/site>
Nov 11 09:16:35 localhost waagent[14455]: from azurelinuxagent.common.event import initialize_event_logger_vminfo_common_parame>
Nov 11 09:16:35 localhost waagent[14455]: File "/nix/store/najm5yzvdysjvrc22m8rjzf8gvhqlbxi-waagent-2.11.1.12/lib/python3.12/site>
Nov 11 09:16:35 localhost waagent[14455]: from azurelinuxagent.common.osutil import get_osutil
Nov 11 09:16:35 localhost waagent[14455]: File "/nix/store/najm5yzvdysjvrc22m8rjzf8gvhqlbxi-waagent-2.11.1.12/lib/python3.12/site>
Nov 11 09:16:35 localhost waagent[14455]: from azurelinuxagent.common.osutil.factory import get_osutil
Nov 11 09:16:35 localhost waagent[14455]: File "/nix/store/najm5yzvdysjvrc22m8rjzf8gvhqlbxi-waagent-2.11.1.12/lib/python3.12/site>
Nov 11 09:16:35 localhost waagent[14455]: from distutils.version import LooseVersion as Version # pylint: disable=no-name-in-m>
Nov 11 09:16:35 localhost waagent[14455]: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Nov 11 09:16:35 localhost waagent[14455]: ModuleNotFoundError: No module named 'distutils'
Nov 11 09:16:35 localhost systemd[1]: waagent.service: Main process exited, code=exited, status=1/FAILURE
Nov 11 09:16:35 localhost systemd[1]: waagent.service: Failed with result 'exit-code'. |
|
Initial findings suggest that Python 3.11 is going to work (the last version to include distutils). We're just reprovisioning a machine to confirm and will make a follow-up PR. |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use latest Python to avoid #353830
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.