Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorpicker: mention more alternatives #353960

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Nov 6, 2024

After the removal of colorpicker, the listed alternatives were not sufficient for me. It was a lightweight "CLI" app in the sense that it didn't open any windows, just printed the color where you clicked next (and with --preview it drew the color you hovered over to the bottom left corner). The mentioned alternatives open a GUI, require an extra button to click to pick colors, doesn't work on minimal systems due to some freedesktop errors, and presumably don't print the color in the terminal, so they can't be used in scripts.

xcolor follows the simplicity of colorpicker so it is a closer alternative and probably other ex-users will want to migrate to that. I don't see much value to deleting the previously mentioned GUI color pickers like eyedropper and gcolor3, so at that point I also added a more featureful GUI alternative called gpick.

cc @Aleksanaa for removing colorpicker in #349744.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 6, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Nov 6, 2024
@Aleksanaa Aleksanaa merged commit 6835d02 into NixOS:master Nov 6, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants