Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wechat-uos: Add hidpi scale support #353957

Merged
merged 1 commit into from
Nov 6, 2024
Merged

wechat-uos: Add hidpi scale support #353957

merged 1 commit into from
Nov 6, 2024
+1 −0

Conversation

pokon548
Copy link
Contributor

@pokon548 pokon548 commented Nov 6, 2024

Add hidpi support for wechat-uos. Reference: https://github.com/flathub/com.tencent.WeChat/blob/b6114c99204680ffbfedbb7ce08856b585471803/com.tencent.WeChat.yaml#L26

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@pokon548 pokon548 marked this pull request as ready for review November 6, 2024 06:50
@pokon548
Copy link
Contributor Author

pokon548 commented Nov 6, 2024

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@pokon548 merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 6, 2024
@ofborg ofborg bot requested a review from xddxdd November 6, 2024 11:02
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 6, 2024
@NickCao NickCao merged commit ae321bd into NixOS:master Nov 6, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wineee wineee wineee approved these changes

@NickCao NickCao NickCao approved these changes

@xddxdd xddxdd Awaiting requested review from xddxdd

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pokon548 @NickCao @wineee @wegank