Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.telegram: removal #353915

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

Kek5chen
Copy link
Contributor

@Kek5chen Kek5chen commented Nov 5, 2024

Things done

Abandonware. Links aren't available anymore. PyPi is available but looks totally abandoned.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from natsukium November 5, 2024 22:05
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Nov 6, 2024
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also add an entry to top-level/python-aliases.nix? Thanks

@Kek5chen
Copy link
Contributor Author

Kek5chen commented Nov 6, 2024

@fabaff done, thanks for mentioning it.

@Aleksanaa Aleksanaa changed the title telegram: removal python3Packages.telegram: removal Nov 6, 2024
@Aleksanaa
Copy link
Member

Don't try to make a big news 😉

@Kek5chen
Copy link
Contributor Author

Kek5chen commented Nov 6, 2024

Sorry, couldn't resist~ hihi

@Aleksanaa Aleksanaa merged commit 7a9fb50 into NixOS:master Nov 6, 2024
28 checks passed
@Kek5chen Kek5chen deleted the remove-telegram branch November 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants