icloudpd: 1.24.0 -> 1.24.3 #353782
Merged
icloudpd: 1.24.0 -> 1.24.3 #353782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 10 packages built:
|
drupol
reviewed
Nov 5, 2024
jnsgruk
force-pushed
the
icloudpd-1.24.3
branch
from
f2560b3
to
daddfda
Compare
jnsgruk
force-pushed
the
icloudpd-1.24.3
branch
from
daddfda
to
d711d8f
Compare
drupol
reviewed
Nov 5, 2024
| @@ -72,8 +72,11 @@ python3Packages.buildPythonApplication rec { | |||
|
|
|||
| preBuild = '' | |||
| substituteInPlace pyproject.toml \ | |||
| --replace "setuptools==69.0.2" "setuptools" \ | |||
| --replace "wheel==0.42.0" "wheel" | |||
| --replace-fail "setuptools==69.0.2" "setuptools" \ | |||
There was a problem hiding this comment.
Why not using pythonRelaxDeps ?
There was a problem hiding this comment.
afaik it doesn't work well with the build system components, or at least in the other python packages I maintain, I've never made it work with setuptools.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Bumped
icloudpdto 1.24.3 and also updated related Python libsrpto 1.0.22nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.