-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildEnv: support ignoreSingleFileOutputs (resumed) #353752
buildEnv: support ignoreSingleFileOutputs (resumed) #353752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be cool to have this because it's not possible from pure nix to know wether a derivation is a single file.
I think we should enforce a policy to exclude all single-file outputs from |
@ShamrockLee, I'd like to merge this once the merge conflict is resolved. |
793c7f2
to
3843aed
Compare
The PR's base branch is set to staging, but 248 commits from the master branch are included. Make sure you know the right base branch for your changes, then:
|
3843aed
to
6bacc2f
Compare
@philiptaron Rebased. |
@Mic92 @philiptaron Regarding the argument name, do you think it should be |
I'm amenable to both, but |
6bacc2f
to
5ca3e70
Compare
Renamed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One copy-editing nit on a comment.
Add option to ignore single-file output instead of failing.
83eb710
to
70038f0
Compare
Rebasd and squashed the commit. |
Add option to ignore single-file output instead of failing, which would be useful to fix Mic92/nixpkgs-review#408.
Cc: @corngood
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.