ngspice: enable OSDI support #352381
Merged
ngspice: enable OSDI support #352381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed this looks harmless enough. |
bgamari
approved these changes
Oct 30, 2024
bgamari
approved these changes
Oct 30, 2024
wegank
added
12.approvals: 1
|
|
I'm not using Nix right now. Can I be removed from the maintainer list of ngspice? |
wegank
approved these changes
Nov 1, 2024
wegank
added
12.approvals: 2
I've added a commit removing you as requested. |
wegank
removed
12.approvals: 2
|
infinisil
pushed a commit
to Infinisil-s-Test-Organization/nixpkgs
that referenced
this pull request
Nov 2, 2024
Shawn8901
pushed a commit
to Shawn8901/nixpkgs
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some open source PDKs like the IHP-Open-PDK require
ngspiceto be compiled with OSDI enabled. For this reason I'm proposing to enable this feature. It allowsngspiceto load several modern Verilog-A models. See section 9.3 of the manualThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)@bgamari @rongcuid @wegank
Add a 👍 reaction to pull requests you find important.