python3Packages.rtmixer: convert to pyproject, fix cross #351972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SFrijters
force-pushed
the
python3-rtmixer
branch
from
7b0a4c3
to
ba3d517
Compare
ofborg
bot
added
6.topic: cross-compilation
wegank
added
the
2.status: merge conflict
Fixes > ModuleNotFoundError: No module named '_cffi_backend' during the build.
SFrijters
force-pushed
the
python3-rtmixer
branch
from
ba3d517
to
c835e6d
Compare
SFrijters
changed the title
SFrijters
removed
the
2.status: merge conflict
|
Version was bumped in #345326, rebased and resolved merge conflict. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change the build process fails for
nix build .#pkgsCross.aarch64-multiplatform.python3Packages.rtmixer, but addingcffitonativeBuildInputsfixes it.I've tested this change at runtime as well by cross-compiling a Python env with this package, copying the closure to a Raspberry Pi, and importing the module on the Raspberry Pi. The build machine is
x86_64and binfmt is disabled (checked by trying to run the cross-compiled environment, and I correctly got "cannot execute binary file: Exec format error").nix path-info -r ./result | grep -v aarchreturns no results so it looks clean to me.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.