Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1password-gui: 8.10.46 -> 8.10.48 (beta 8.10.48-17 -> 8.10.50-8) #350364

Merged
merged 1 commit into from
Oct 26, 2024

Conversation

SebTM
Copy link
Contributor

@SebTM SebTM commented Oct 21, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SebTM
Copy link
Contributor Author

SebTM commented Oct 21, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350364


x86_64-linux

✅ 2 packages built:
  • _1password-gui
  • _1password-gui-beta

@ofborg ofborg bot requested a review from timstott October 22, 2024 04:30
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Oct 22, 2024
@khaneliman
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350364


x86_64-linux

✅ 2 packages built:
  • _1password-gui
  • _1password-gui-beta

aarch64-linux

✅ 2 packages built:
  • _1password-gui
  • _1password-gui-beta

x86_64-darwin

⏩ 2 packages marked as broken and skipped:
  • _1password-gui
  • _1password-gui-beta

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • _1password-gui
  • _1password-gui-beta

Copy link
Contributor

@khaneliman khaneliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SebTM SebTM added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 22, 2024
@SebTM SebTM merged commit a8a4113 into master Oct 26, 2024
48 checks passed
@SebTM SebTM deleted the 1pwd_1024 branch October 26, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants