Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.opentelemetry-proto: use protobuf4 #349365

Closed

Conversation

jackwilsdon
Copy link
Contributor

Fixes #349361.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

opentelemetry-proto doesn't support Protobuf 5 yet.
@jackwilsdon
Copy link
Contributor Author

Upstream has added support for Protobuf 5 but it hasn't made its way into a release yet: open-telemetry/opentelemetry-python#4206

@jackwilsdon
Copy link
Contributor Author

jackwilsdon commented Oct 17, 2024

Seems like a number of dependencies on this package have issues building after this change, giving errors like this:

found duplicated packages in closure for dependency 'protobuf': 
  protobuf 5.28.2 (/nix/store/3sgy4wi9zab1j5cpb595aw12d7qjkbkc-python3.12-protobuf-5.28.2)
    dependency chain:
      this derivation: /nix/store/qrqbppkxh0mcz5cbpac303mjvfsrfrp8-python3.12-opentelemetry-exporter-otlp-proto-grpc-1.26.0
      ...depending on: /nix/store/dgsq8gik07pmdxsc51rv145rck0j4z61-python3.12-googleapis-common-protos-1.63.1
      ...depending on: /nix/store/3sgy4wi9zab1j5cpb595aw12d7qjkbkc-python3.12-protobuf-5.28.2
  protobuf 4.25.4 (/nix/store/7q447r8za2233grairjgkrr6al49v0ql-python3.12-protobuf-4.25.4)
    dependency chain:
      this derivation: /nix/store/qrqbppkxh0mcz5cbpac303mjvfsrfrp8-python3.12-opentelemetry-exporter-otlp-proto-grpc-1.26.0
      ...depending on: /nix/store/73scs999mwv61ilb9wczbhy4p3cvnpra-python3.12-opentelemetry-exporter-otlp-proto-common-1.26.0
      ...depending on: /nix/store/nx5z9i75d0sawd5p5d6djm52gr45fxpg-python3.12-opentelemetry-proto-1.26.0
      ...depending on: /nix/store/7q447r8za2233grairjgkrr6al49v0ql-python3.12-protobuf-4.25.4

@jackwilsdon
Copy link
Contributor Author

Looks like this has already been fixed on staging: #348738.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: opentelemetry-proto
1 participant