Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkgsStatic.dtc: fix build #349201

Merged
merged 1 commit into from
Oct 31, 2024
Merged

pkgsStatic.dtc: fix build #349201

merged 1 commit into from
Oct 31, 2024

Conversation

baloo
Copy link
Member

@baloo baloo commented Oct 17, 2024

Before this fix, dtc will not build on static.

This pulls fixes in the upstream PR: dgibson/dtc#141

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from dezgeg October 17, 2024 05:48
@katexochen katexochen mentioned this pull request Oct 17, 2024
Merged
1 task
@baloo baloo force-pushed the baloo/dtc/fix-static-build branch 2 times, most recently from 1809458 to b3b6e1a Compare October 23, 2024 06:15
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4750

@ShamrockLee
Copy link
Contributor

@ofborg build pkgsStatic.dtc

@baloo baloo force-pushed the baloo/dtc/fix-static-build branch from b3b6e1a to 6f5a437 Compare October 27, 2024 19:56
@ShamrockLee
Copy link
Contributor

@ofborg build pkgsStatic.dtc

@ShamrockLee
Copy link
Contributor

@ofborg build dtc

ShamrockLee
ShamrockLee approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@ShamrockLee ShamrockLee left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the hashes and ensured the commit was from the upstream PR. Though not yet merged, the upstream PR was approved by the upstream people.

nixpkgs-review stumbled upon Mic92/nixpkgs-review#408, but most changed packages were built successfully, with only 8 build failures. Some build failures are caused by failing to fetch the source. (Building them takes hours and tens of gibibytes of storage.)

I'm unsure if such changes that rebuild ~200 of packages on Linux should be merged into staging instead, and I haven't tested the device tree compiler's functionality manually. Otherwise, LGTM.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 28, 2024
@baloo baloo marked this pull request as draft October 28, 2024 16:00
@baloo baloo changed the base branch from master to staging October 28, 2024 16:01
@baloo baloo force-pushed the baloo/dtc/fix-static-build branch from 6f5a437 to 3d2dfab Compare October 28, 2024 16:01
@baloo baloo marked this pull request as ready for review October 28, 2024 16:01
@baloo
Copy link
Member Author

baloo commented Oct 28, 2024

@ShamrockLee yeah, that's a good point, I misread the previous label, I thought it was impacting less than 100 packages. I retargeted to staging.

@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@baloo baloo force-pushed the baloo/dtc/fix-static-build branch from 3d2dfab to b363747 Compare October 30, 2024 17:00
@ShamrockLee
Copy link
Contributor

@ofborg build pkgsStatic.dtc
@ofborg build dtc
@ofborg build VirtualBox
@ofborg build qemu

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Oct 31, 2024 •
edited
Loading

@ofborg build virtualbox

@SuperSandro2000 SuperSandro2000 merged commit c1100dd into NixOS:staging Oct 31, 2024
37 of 41 checks passed
@baloo baloo deleted the baloo/dtc/fix-static-build branch October 31, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShamrockLee ShamrockLee ShamrockLee approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@dezgeg dezgeg Awaiting requested review from dezgeg

Assignees
No one assigned
Labels
6.topic: static 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@baloo @nixos-discourse @ShamrockLee @SuperSandro2000 @wegank @FliegendeWurst