Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3{11,12}Packages.mhcflurry: remove unused nose input #348716

Merged
merged 1 commit into from
Oct 15, 2024
Merged

python3{11,12}Packages.mhcflurry: remove unused nose input #348716

merged 1 commit into from
Oct 15, 2024
+0 −1

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Oct 15, 2024

Fixes: 8574a14

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This was referenced Oct 15, 2024
Merged
Merged
@Scrumplex Scrumplex added the 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people label Oct 15, 2024
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348716

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

@emilazy emilazy merged commit 7881fbf into NixOS:master Oct 15, 2024
11 of 12 checks passed
@emilazy emilazy deleted the push-lzoqrzzyvnqv branch October 15, 2024 08:13
@emilazy emilazy mentioned this pull request Oct 15, 2024
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyrox0 pyrox0 pyrox0 approved these changes

@GaetanLepage GaetanLepage GaetanLepage approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 3+ This PR was reviewed and approved by three or more reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@emilazy @GaetanLepage @Scrumplex @pyrox0