Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/tests/redmine: Limit platforms to supported ones #348178

Merged

Conversation

felixsinger
Copy link
Member

@felixsinger felixsinger commented Oct 13, 2024

In order to avoid unnecessary CI errors regarding unsupported architectures, limit the target architectures to the supported ones by the Redmine package.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 13, 2024
In order to avoid unnecessary CI errors regarding unsupported
architectures, limit the target architectures to the supported ones by
the Redmine package.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
@felixsinger felixsinger force-pushed the nixos/tests/redmine/limit-archs branch from c53342e to e7f53bf Compare October 13, 2024 01:40
@felixsinger felixsinger changed the title nixos/tests/redmine: Limit architectures to supported ones nixos/redmine: Limit architectures to supported ones Oct 13, 2024
@felixsinger felixsinger changed the title nixos/redmine: Limit architectures to supported ones nixos/tests/redmine: Limit architectures to supported ones Oct 13, 2024
@felixsinger
Copy link
Member Author

@GrahamcOfBorg test redmine

@felixsinger
Copy link
Member Author

@aanderse @megheaiulian Just trying to make the CI log a bit cleaner and remove unnecessary errors with this. See #348182. Maybe there's a general solution for this?

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Oct 13, 2024
@felixsinger felixsinger changed the title nixos/tests/redmine: Limit architectures to supported ones nixos/tests/redmine: Limit platforms to supported ones Oct 16, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 6, 2024
@SuperSandro2000 SuperSandro2000 merged commit 90a1d75 into NixOS:master Nov 6, 2024
51 checks passed
@felixsinger felixsinger deleted the nixos/tests/redmine/limit-archs branch November 6, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants