Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci/request-reviews: Avoid duplicates with different casings #348030

Merged
merged 1 commit into from
Oct 12, 2024

Conversation

infinisil
Copy link
Member

It's possible to have different casings in OWNERS, so we need to handle that

Seen in https://github.com/NixOS/nixpkgs/actions/runs/11302175036/job/31437638469?pr=347626 where it tried requesting a review from Infinisil because it's declared with that casing:

/pkgs/development/idris-modules @Infinisil
, and the PR author check didn't filter this out because my username is infinisil.

Things done

  • Ran it locally and verified that I don't appear in the list anymore:
    $ nb -A requestReviews
    $ DRY_MODE=1 result/bin/request-reviews.sh NixOS/nixpkgs 347626 ci/OWNERS
    

This work is sponsored by Antithesis

Add a 👍 reaction to pull requests you find important.

It's possible to have different casings in OWNERS, so we need to handle
that
@emilazy emilazy merged commit bb75274 into NixOS:master Oct 12, 2024
10 of 11 checks passed
@infinisil infinisil deleted the owners-casing branch October 31, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants