ryujinx: archive.org tarball mirror #346694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failed: |
|
CI is already unhappy, because you can’t use You want |
Thank you ! It's indeed |
Nabile-Rahmani
force-pushed
the
ryujinx-mirror-unstable
branch
from
bdfa4b9
to
c61d421
Compare
Should fix source builds by relying on our beloved archive.org to host a [SHA256-matching tarball generated from a mirror of the repo](https://archive.org/details/ryujinx-5dbba-07e-33e-83c-9047dcbb-701c-9655edbbe-89086.tar). I have only `nix repl`'d the fetchTarball expression for its consistency check, as I do not currently have the time nor storage to build the package locally, sorry about that. We could also generate archives to address NixOS#345410 and the 24.05 branch. Supersedes: NixOS#345881
Nabile-Rahmani
force-pushed
the
ryujinx-mirror-unstable
branch
from
c61d421
to
59a5a09
Compare
emilazy
approved these changes
Oct 5, 2024
Nabile-Rahmani
added a commit
to Nabile-Rahmani/nixpkgs
that referenced
this pull request
Oct 5, 2024
Fixes source builds for 24.05, as per [emilazy's request](NixOS#346694 (review)). Like on master, fetchzip requires the hash attribute to be explicit, double check it with `nix hash to-sri --type sha256 1vf4xwn1z7bfm7c49r2yydx3dqqzqwp0qgzq12m9yskqsj898d63`.
13 tasks
This was referenced Oct 6, 2024
presto8
pushed a commit
to presto8/nixpkgs
that referenced
this pull request
Oct 9, 2024
Fixes source builds for 24.05, as per [emilazy's request](NixOS#346694 (review)). Like on master, fetchzip requires the hash attribute to be explicit, double check it with `nix hash to-sri --type sha256 1vf4xwn1z7bfm7c49r2yydx3dqqzqwp0qgzq12m9yskqsj898d63`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix source builds by relying on our beloved archive.org to host a SHA256-matching tarball generated from a mirror of the repo.
I have only
nix repl'd the fetchTarball expression for its consistency check, as I do not currently have the time nor storage to build the package locally, sorry about that.We could also generate archives to address #345410 and the 24.05 branch.
Supersedes: #345881
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.