Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

odoo: fix tests and update #344173

Closed
wants to merge 20 commits into from
Closed

Conversation

phanirithvij
Copy link
Member

@phanirithvij phanirithvij commented Sep 24, 2024

Description of changes

fix odoo package tests. (also fixes furl tests #320020 (comment))

echo nixosTests.odoo{,15,16} | xargs -n1 nix-build --no-out-link -A
echo python3{9,10,11,12,13}Packages.furl | xargs -n1 nix-build --no-out-link -A
echo pypy{3,39,310}Packages.furl | xargs -n1 nix-build --no-out-link -A

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

cc: @mweinelt

Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put the aiohttp, flake8, and pyflakes changes in a separate PR?

pkgs/by-name/od/odoo/package.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/furl/default.nix Outdated Show resolved Hide resolved
@phanirithvij
Copy link
Member Author

Can we put the aiohttp, flake8, and pyflakes changes in a separate PR?

odoo test requires these to pass, how does having these in a separate pr help?

@dotlambda
Copy link
Member

Can we put the aiohttp, flake8, and pyflakes changes in a separate PR?

odoo test requires these to pass, how does having these in a separate pr help?

How so? The packages build just fine on master.

@phanirithvij
Copy link
Member Author

odoo requires 310.furl, 310.aiohttp, 310.websockets

broken in master
furl 39, 310, 313
aiohttp 39 (unsupported), 310, 311, 313
websockets 39, 310 (staging)

in master (this pr's commits)

broken
furl
aiohttp 39 (unsupported), 313
websockets 310 (staging)

flake8, pyflakes are broken for pypy and 313 so I will make a separate pr.

@phanirithvij phanirithvij changed the title odoo: fix tests odoo: fix tests and update Sep 25, 2024
@phanirithvij
Copy link
Member Author

phanirithvij commented Sep 25, 2024

I don't know if any functionality breaks in odoo during runtime due to the changes I made in odoo15 and odoo16. can someone who uses odoo test the binaries/service are working and have no obvious regressions? @mkg20001 @siriobalmelli ?

the basic nixos tests pass for all versions.

$ echo nixosTests.odoo{,15,16} | xargs -n1 nix-build --no-out-link -A
/nix/store/q07i71157l7v00bq51rb4acilx334hip-vm-test-run-odoo
/nix/store/1rh0y82rxf27cwifily41h018bq93hkb-vm-test-run-odoo
/nix/store/mkdr4w9wmv4zccbvwzggp8j7067mzsbl-vm-test-run-odoo

@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Sep 25, 2024
@mkg20001
Copy link
Member

@phanirithvij I currently don't have any odoo install to test, but since the tests also check if the odoo instance responds to requests after starting it also checks (a bit) of the runtime stuff.

Shouldn't cause any big breakage.

@mkg20001
Copy link
Member

But others should feel free to test and report. Let's give it a day or two.

@phanirithvij
Copy link
Member Author

I seem to have messed this up, apologies, will open a new one.

@siriobalmelli
Copy link
Contributor

@phanirithvij for the record I really appreciate your help getting odoo into shape.

I have been traveling and haven't had a chance to spin up a test instance to validate, but should have time to pitch in and help get this sorted towards the beginning of next week. Please tag me when you open a new PR or re-open this one 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants