-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
liana: 6.0 -> 8.0 #343429
liana: 6.0 -> 8.0 #343429
Conversation
|
edf9e57
to
8a422d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
tACK. tested on |
It's now possible to get rid of the lock file using |
Great! I'll update this PR when I get the chance. |
Ah, looks like that's not possible for liana as git dependencies are not supported for the fetcher yet:
|
It was designed specifically to handle git dependencies, you just need to rebase your PR. |
Yeah you're right, pulled master and didn't actually rebase this branch 🤦♂️ Edit: And I would have realised this mistake if I had actually used |
8a422d9
to
2ebd6b6
Compare
Description of changes
Release Notes:
https://github.com/wizardsardine/liana/releases/tag/v7.0
https://github.com/wizardsardine/liana/releases/tag/v8.0
Changes: wizardsardine/liana@v6.0...v8.0
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.