Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

materia-theme-transparent: init at 0-unstable-2024-03-22 #343373

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

CorbinWunderlich
Copy link
Contributor

@CorbinWunderlich CorbinWunderlich commented Sep 20, 2024

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Sep 20, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Sep 20, 2024
@CorbinWunderlich CorbinWunderlich changed the title Materia theme transparent materia-theme-transparent: init at 20210322 Sep 23, 2024
@CorbinWunderlich
Copy link
Contributor Author

Went back and squashed the commits.

@FliegendeWurst FliegendeWurst added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 2, 2024
@CorbinWunderlich CorbinWunderlich force-pushed the materia-theme-transparent branch 2 times, most recently from 6dd9713 to b329619 Compare November 3, 2024 22:53
@CorbinWunderlich
Copy link
Contributor Author

@FliegendeWurst I applied your patches, and it still builds fine. Thanks for the suggestions :)

@CorbinWunderlich CorbinWunderlich force-pushed the materia-theme-transparent branch 3 times, most recently from df5b943 to fccff5a Compare November 4, 2024 22:43
@CorbinWunderlich CorbinWunderlich changed the title materia-theme-transparent: init at 20210322 materia-theme-transparent: init at 0-unstable-2024-03-22 Nov 6, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-linux: 1-10 labels Nov 6, 2024
@ofborg ofborg bot added 10.rebuild-linux: 1 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild labels Nov 6, 2024
@CorbinWunderlich
Copy link
Contributor Author

Any other changes I need to make before merging?

@Aleksanaa Aleksanaa merged commit 9f737b7 into NixOS:master Nov 7, 2024
32 of 33 checks passed
@Aleksanaa
Copy link
Member

Oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants